feat: add ping, dns and traceroute for technicolor devices #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 2
Lines ? 14
Branches ? 0
========================================
Hits ? 14
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
pschmitt
force-pushed
the
ping-and-traceroute
branch
from
4801fca to
c2338e9
Compare
|
All right, I fixed the mypi issue and squashed. |
pschmitt
changed the title
pschmitt
force-pushed
the
ping-and-traceroute
branch
from
c2338e9 to
4dbb4ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ping, traceroute and dns resolution funcs, ie these:
I don't know how to handle the other device type, since I don't own that one and therefore don't even know if this is supported at all. For now it just raises
NotImplementedErrorat runtime.