Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix publickey encoding && Add assertionMethod #43

Closed
wants to merge 1 commit into from

Conversation

DaevMithran
Copy link
Contributor

@DaevMithran DaevMithran commented Sep 22, 2022

Signed-off-by: DaevMithran daevmithran1999@gmail.com

This pull request

  • Adds an assertionMethod in the didDocument
  • encodes the publicKey using MULTICODEC_ED25519_PUB_HEADER = new Uint8Array([0xed, 0x01]) which is followed in did:key spec, and the signature suites for publicKeyMultibase BREAKING CHANGE: This will need changes in cheqd/node

Both the changes were needed to support JSONLD credentials.

References

Signed-off-by: DaevMithran <daevmithran1999@gmail.com>
@Eengineer1
Copy link
Contributor

@DaevMithran Thanks for pointing out.
This PR is needed right after switching to header prefix ledger-side as well.
Till then, let's focus on overriding the Veramo signer.

Closing this, as there will be many extensive changes needed in the SDK signing as well, not only those present here.

Let me know your thoughts.

@Eengineer1 Eengineer1 closed this Sep 22, 2022
@DaevMithran
Copy link
Contributor Author

DaevMithran commented Sep 23, 2022

@Eengineer1 Can you please point out the code where we need to change the SDK's signing logic. I think there's no need for that.

  • Other than that I can create a separate PR for adding assertion method in the didDoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants