Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Make temporary solution for API key [DEV-3400] #425

Merged
merged 7 commits into from
Nov 15, 2023
Merged

chore: Make temporary solution for API key [DEV-3400] #425

merged 7 commits into from
Nov 15, 2023

Conversation

lampkin-diet
Copy link
Contributor

Added:

  • small refactoring for API guarding
  • add endpoint for getting idToken
  • add apiKey table and tracking API keys

@ankurdotb
Copy link
Contributor

Task linked: DEV-3400 Add makeFeePayment parameter for /credential/verify and for /presentation/verify

Eengineer1
Eengineer1 requested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Left remarks considering error handling edge cases to resolve, other than that, that's good to go.

src/middleware/auth/user-info-fetcher/api-token.ts Outdated Show resolved Hide resolved
@lampkin-diet lampkin-diet merged commit 5e6cdf4 into develop Nov 15, 2023
8 checks passed
@lampkin-diet lampkin-diet deleted the DEV-3400 branch November 15, 2023 08:57
@cheqd-bot
Copy link

cheqd-bot bot commented Dec 8, 2023

🎉 This PR is included in version 2.12.0-develop.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot
Copy link

cheqd-bot bot commented Dec 20, 2023

🎉 This PR is included in version 2.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eengineer1 Eengineer1 Eengineer1 requested changes

Assignees
No one assigned
Labels
released on @beta released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lampkin-diet @ankurdotb @Eengineer1