Bug Fix - Tab Crashes when page limit exceeds a certain amout (e.g. 10000) on explore community tab. #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the Explore community tab
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
ajbura
added a commit
to cinnyapp/cla
that referenced
this pull request
Dec 22, 2024
ajbura
requested changes
Jan 6, 2025
ajbura
requested changes
Feb 16, 2025
Comment on lines
+320
to
+324
| onChange={(e: React.ChangeEvent<HTMLInputElement>) => { | ||
| if (parseInt(e.target.value) > 10000) { | ||
| e.target.value = e.target.value.slice(0, 4); | ||
| } | ||
| }} |
There was a problem hiding this comment.
please remove the onChange as it is not required after adding max and also will break the input from changing value.
Comment on lines
+304
to
+306
| <Chip variant="SurfaceVariant" onClick={() => setLimit('10000')} radii="Pill"> | ||
| <Text size="T200">Max</Text> | ||
| </Chip> |
There was a problem hiding this comment.
It won't be a good idea to show this option considering that the performance will be poor.
| </Box> | ||
| </Box> | ||
| <Box as="form" onSubmit={handleLimitSubmit} direction="Column" gap="300"> | ||
| <Box direction="Column" gap="100"> | ||
| <Text size="L400">Custom Limit</Text> | ||
| <Input | ||
| placeholder="Max limit- 10000" |
There was a problem hiding this comment.
that placeholder is misleading and not required as input already has a label
| @@ -45,6 +45,7 @@ import { getMxIdServer } from '../../../utils/matrix'; | |||
| import { stopPropagation } from '../../../utils/keyboard'; | |||
| import { ScreenSize, useScreenSizeContext } from '../../../hooks/useScreenSize'; | |||
| import { BackRouteHandler } from '../../../components/BackRouteHandler'; | |||
| // import { LimitWarning } from './LimitWarning'; | |||
There was a problem hiding this comment.
please remove the commented code
| @@ -260,6 +261,7 @@ function LimitButton({ limit, onLimitChange }: LimitButtonProps) { | |||
| if (!limitInput) return; | |||
| const newLimit = limitInput.value.trim(); | |||
| if (!newLimit) return; | |||
| // my work here | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2072
Before Changes:
https://github.com/user-attachments/assets/cc3674ad-18d6-40a2-9225-19569765daea
After Changes:
https://github.com/user-attachments/assets/1761a3b7-eb62-47a5-a766-e06dc2945887
Type of change
Checklist: