-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add mobile gesture (again) #2171
base: dev
Are you sure you want to change the base?
feat: Add mobile gesture (again) #2171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@North-West-Wind does this fixes any ongoing issue? Cinny now support url navigation which allow user to use mobile native back and forward gesture.
I didn't really focus on existing issues. |
As it go against the url navigation, I think we should not continue with it as it might lead to further unwanted complication in overall app navigation. |
It does use URL navigation though. For example, when using the slide menu in a room, it changes the URL back to the space URL, and the "back" navigation works to bring it back to the room page. The trigger for URL change is when the slide menu completely opens. |
Preview: https://2171--pr-cinny.netlify.app |
I’ve tested it on mobile, and here are my thoughts:
Given the trade-off between the value this change provides and the user experience impact, I think it might not be worth implementing. |
Hmm, well then. I'll see if I have time to work on it in the future. Thank you for reviewing this :> |
Description
As Tauri 2.0 released with mobile support, better mobile features seems to be getting more important.
This is a re-entry of #1647, which was written for Cinny v3, and then Cinny updated to v4 with major refactors and the code no longer works. It's until now I finally have time to rewrite the features, and I hope the same doesn't happen again.
This PR brings in 2 mobile gestures:
Type of change
Checklist:
I have made corresponding changes to the documentation