Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mobile gesture (again) #2171

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

North-West-Wind
Copy link

Description

As Tauri 2.0 released with mobile support, better mobile features seems to be getting more important.
This is a re-entry of #1647, which was written for Cinny v3, and then Cinny updated to v4 with major refactors and the code no longer works. It's until now I finally have time to rewrite the features, and I hope the same doesn't happen again.

This PR brings in 2 mobile gestures:

  • Swipe right menu
  • Swipe left reply

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@North-West-Wind North-West-Wind changed the title Add mobile gesture (again) feat: Add mobile gesture (again) Jan 24, 2025
Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@North-West-Wind does this fixes any ongoing issue? Cinny now support url navigation which allow user to use mobile native back and forward gesture.

@North-West-Wind
Copy link
Author

I didn't really focus on existing issues.
I'm aware that Cinny now supports URL navigation, but a slide menu looks nicer.

@ajbura
Copy link
Member

ajbura commented Feb 16, 2025

As it go against the url navigation, I think we should not continue with it as it might lead to further unwanted complication in overall app navigation.

@North-West-Wind
Copy link
Author

North-West-Wind commented Feb 16, 2025

It does use URL navigation though. For example, when using the slide menu in a room, it changes the URL back to the space URL, and the "back" navigation works to bring it back to the room page.

The trigger for URL change is when the slide menu completely opens.

Copy link

Preview: https://2171--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ajbura
Copy link
Member

ajbura commented Feb 16, 2025

I’ve tested it on mobile, and here are my thoughts:

  • The slide animation feels like a drawer(which is fading in mobile world), which causes the back screen to appear after the animation. This conflicts with the native back gestures on mobile and browser.
  • The swipe-left-to-reply functionality causes the content to shift left when scrolling back.

Given the trade-off between the value this change provides and the user experience impact, I think it might not be worth implementing.

@North-West-Wind
Copy link
Author

Hmm, well then. I'll see if I have time to work on it in the future. Thank you for reviewing this :>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants