Add A300 to supported platforms #63
Conversation
civerachb-cpr
requested review from
mhosmar-cpr and
roni-kreinin
and removed request for
a team
| @@ -163,6 +163,10 @@ def __init__(self, setup_path: str = '/etc/clearpath/') -> None: | |||
| self.cmd_vel_node, | |||
| self.odom_base_node, | |||
| ], | |||
| Platform.A300: [ | |||
There was a problem hiding this comment.
Lets make a common platform components array to hold the cmd_vel_node and odom_base_node since all robots will use these. Same way we did it here: https://github.com/clearpathrobotics/clearpath_robot/blob/a88192de11edf7425e968fd9fa730435181fff3c/clearpath_generator_robot/clearpath_generator_robot/launch/generator.py#L231
There was a problem hiding this comment.
Taken a first-pass at implementing this.
| @@ -237,7 +220,7 @@ def generate_platform(self) -> None: | |||
| platform_service_launch_writer.add_launch_file(self.platform_launch_file) | |||
|
|
|||
| # Platform components | |||
| for component in self.platform_components[self.platform_model]: | |||
| for component in self.latform_components[self.platform_model]: | |||
There was a problem hiding this comment.
...how did that not trigger an error when i tested it? now i have so many questions about what's wrong with my environment. that's alarming...
|
This may be a wider CI question but CI is failing to install clearpath_generator_common and clearpath_viz. Are these externally available? |
|
I'll answer my own question. They don't seem to be released in Jazzy yet. |
No description provided.