style: update formatting based on feedback (#546)

clevercanary · Jan 11, 2024 · f44075e · f44075e
1 parent 1556701
commit f44075e
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 18 deletions.
diff --git a/packages/data-explorer-ui/src/components/Filter/components/FilterMenu/filterMenu.tsx b/packages/data-explorer-ui/src/components/Filter/components/FilterMenu/filterMenu.tsx
@@ -3,10 +3,10 @@ import {
   CategoryKey,
   SelectCategoryValueView,
 } from "../../../../common/entities";
-import { FilterMenuSearchMatch } from "../../../../components/Filter/common/entities";
 import { OnFilterFn } from "../../../../hooks/useCategoryFilter";
 import { SouthIcon } from "../../../common/CustomIcon/components/SouthIcon/southIcon";
 import { MAX_DISPLAYABLE_LIST_ITEMS } from "../../common/constants";
+import { FilterMenuSearchMatch } from "../../common/entities";
 import { getSortMatchesFn } from "../../common/utils";
 import { List } from "../FilterList/filterList.styles";
 import { FilterMenuSearch } from "../FilterMenuSearch/filterMenuSearch";

diff --git a/...-explorer-ui/src/components/Filter/components/HighlightedLabel/highlightedLabel.styles.ts b/...-explorer-ui/src/components/Filter/components/HighlightedLabel/highlightedLabel.styles.ts
@@ -14,14 +14,14 @@ export const MatchHighlight = styled.mark<MatchHighlightProps>`
   ${({ leftOpen }) =>
     leftOpen &&
     css`
-      padding-left: 2px;
       margin-left: -2px;
+      padding-left: 2px;
     `}
 
   ${({ rightOpen }) =>
     rightOpen &&
     css`
-      padding-right: 2px;
       margin-right: -2px;
+      padding-right: 2px;
     `}
 `;
diff --git a/...s/data-explorer-ui/src/components/Filter/components/HighlightedLabel/highlightedLabel.tsx b/...s/data-explorer-ui/src/components/Filter/components/HighlightedLabel/highlightedLabel.tsx
@@ -1,5 +1,5 @@
 import React from "react";
-import { FilterMenuSearchMatchRange } from "../../../../components/Filter/common/entities";
+import { FilterMenuSearchMatchRange } from "../../common/entities";
 import { MatchHighlight } from "./highlightedLabel.styles";
 
 interface HighlightedLabelProps {

diff --git a/...lter/components/SearchAllFilters/components/VariableSizeListItem/variableSizeListItem.tsx b/...lter/components/SearchAllFilters/components/VariableSizeListItem/variableSizeListItem.tsx
@@ -64,12 +64,7 @@ export default function VariableSizeListItem({
         />
         <ListItemText
           disableTypography
-          primary={
-            <HighlightedLabel
-              label={label}
-              ranges={matchRanges}
-            ></HighlightedLabel>
-          }
+          primary={<HighlightedLabel label={label} ranges={matchRanges} />}
           secondary={
             <Typography color="ink.light" variant={TEXT_BODY_SMALL_400}>
               {count}

diff --git a/...s/data-explorer-ui/src/components/Filter/components/VariableSizeList/VariableSizeList.tsx b/...s/data-explorer-ui/src/components/Filter/components/VariableSizeList/VariableSizeList.tsx
@@ -5,7 +5,6 @@ import {
   VariableSizeListProps as ListProps,
 } from "react-window";
 import { CategoryKey } from "../../../../common/entities";
-import { FilterMenuSearchMatch } from "../../../../components/Filter/common/entities";
 import { OnFilterFn } from "../../../../hooks/useCategoryFilter";
 import { useWindowResize } from "../../../../hooks/useWindowResize";
 import {
@@ -14,6 +13,7 @@ import {
   MAX_DISPLAYABLE_LIST_ITEMS,
   MAX_LIST_HEIGHT_PX,
 } from "../../common/constants";
+import { FilterMenuSearchMatch } from "../../common/entities";
 import { List as FilterList } from "../FilterList/filterList.styles";
 import VariableSizeListItem from "../VariableSizeListItem/variableSizeListItem";
 

diff --git a/...xplorer-ui/src/components/Filter/components/VariableSizeListItem/variableSizeListItem.tsx b/...xplorer-ui/src/components/Filter/components/VariableSizeListItem/variableSizeListItem.tsx
@@ -6,11 +6,11 @@ import {
 } from "@mui/material";
 import React, { CSSProperties, useEffect, useRef } from "react";
 import { CategoryKey } from "../../../../common/entities";
-import { FilterMenuSearchMatch } from "../../../../components/Filter/common/entities";
 import { OnFilterFn } from "../../../../hooks/useCategoryFilter";
 import { TEXT_BODY_SMALL_400 } from "../../../../theme/common/typography";
 import { CheckedIcon } from "../../../common/CustomIcon/components/CheckedIcon/checkedIcon";
 import { UncheckedIcon } from "../../../common/CustomIcon/components/UncheckedIcon/uncheckedIcon";
+import { FilterMenuSearchMatch } from "../../common/entities";
 import { HighlightedLabel } from "../HighlightedLabel/highlightedLabel";
 
 interface Props {
@@ -60,12 +60,7 @@ export default function VariableSizeListItem({
       />
       <ListItemText
         disableTypography
-        primary={
-          <HighlightedLabel
-            label={label}
-            ranges={labelRanges}
-          ></HighlightedLabel>
-        }
+        primary={<HighlightedLabel label={label} ranges={labelRanges} />}
         secondary={
           <Typography color="ink.light" variant={TEXT_BODY_SMALL_400}>
             {count}