ci: publish: Move to release tag triggered publishing #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still prefer my old GitHub UI triggered release. It feels much less complicated to me. But this project is part of clj-commons, and here I defer to the larger team's preference for release triggered publishing. I brought over this work from other projects, mostly rewrite-clj and pomegranate. These incude: - using neil to track/bump/store version in deps.edn - automatically including date in changelog release headers One refinement for Etaoin is avoiding the duplicate test run on Publish. The release tag triggered strategy includes a commit and tag from the person doing the publish. This commit triggers the normal Test workflow but the Publish workflow also triggers the Test workflow to ensure all is good before releasing. To avoid the duplicate test run, I've added a new `check-for-skip` job in the Test workflow to skip tests when appropriate. I'd love to skip the independent Test workflow on Publish entirely, but don't think the GitHub Actions YAML magic to do so exists. Closes #529
Since the check-for-skip work needs pretty much the same setup as the setup job, merge the two and avoid the extra job.
A wee sanity test
On a PR the commit message is the merge commit. That's not important to me, I care about behaviour on master, the branch from which we publish.
|
GitHub manual Config:
|
lread
added a commit
to dgr/etaoin
that referenced
this pull request
Aug 13, 2024
* master: Move to w3c WebDriver spec (clj-commons#616) minor breaking: Remove support for PhantomJS (clj-commons#614) ci: publish: Move to release tag triggered publishing (clj-commons#611) docs: review & update changelog (clj-commons#610) Minimal safari driver logging (clj-commons#601) Ignore emacs backup files (clj-commons#609)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still prefer my old GitHub UI triggered release. It feels much less complicated to me. But this project is part of clj-commons, and here I defer to the larger team's preference for release triggered publishing.
I brought over this work from other projects, mostly rewrite-clj and pomegranate. These incude:
One refinement for Etaoin is avoiding the duplicate test run on Publish. The release tag triggered strategy includes a commit and tag from the person doing the publish. This commit triggers the normal Test workflow but the Publish workflow also triggers the Test workflow to ensure all is good before releasing. To avoid the duplicate test run, I've added a new
check-for-skipjob in the Test workflow to skip tests when appropriate. I'd love to skip the independent Test workflow on Publish entirely, but don't think the GitHub Actions YAML magic to do so exists.Closes #529
Please complete and include the following checklist:
I have read CONTRIBUTING and the Etaoin Developer Guide.
This PR corresponds to an issue that the Etaoin maintainers have agreed to address.
This PR contains test(s) to protect against future regressions
I have updated CHANGELOG.adoc with a description of the addressed issue.