only log if the permission is changed

[kickster97]

WHAT is this pull request doing?

Don't log thet the permission is updated if the permission is the same that we already have.
I tried opting for an early return.. but it looks like we do this on launch, and if we don't have a default user we can't create one.

Oskar also gave his two cents, and makes the case that we could change these permissions updates in ssh-monitor.. and hat we should log because we do the update.

HOW can this pull request be tested?

try to update permissions without changing them

[viktorerlingsson]

Looks good to me.

Maybe we could also move these rows inside the unless? If the permissions are the same there shouldn't be a need to update and save them.

@users[user].permissions[vhost] = perm
@users[user].invalidate_acl_caches
save!

[kickster97]

Looks good to me.

Maybe we could also move these rows inside the unless? If the permissions are the same there shouldn't be a need to update and save them.

@users[user].permissions[vhost] = perm
@users[user].invalidate_acl_caches
save!

I tried this, but if we don't have a user this wont work.. and its run at launch when we don't have one yet so then it fails :)

[viktorerlingsson]

I tried this, but if we don't have a user this wont work.. and its run at launch when we don't have one yet so then it fails :)

Okay!