Drop overflow in loop for stream_queue to make sure max-age is respected #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sure segments with old messages are removed
carlhoerberg
requested changes
Dec 7, 2023
Co-authored-by: Carl Hörberg <carl@84codes.com>
carlhoerberg
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Replaces
unmap_unused_segments_loopwithunmap_and_remove_segments_loop. The new function also removes segments from stream queues where all messages are past max-age.HOW can this pull request be tested?
Create a stream queue with max-age (ex. 60s).
Publish more messages than fits in one segment file.
Wait the max-age to pass and for the loop to run.
Check that the older segment file has been deleted.