Dont use shovel name as consumer tag #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lavinmq/shovel/shovel.cr
Outdated
| @@ -44,7 +44,7 @@ module LavinMQ | |||
| @delete_after = DEFAULT_DELETE_AFTER, @prefetch = DEFAULT_PREFETCH, | |||
| @ack_mode = DEFAULT_ACK_MODE, consumer_args : Hash(String, JSON::Any)? = nil, | |||
| direct_user : User? = nil) | |||
| @tag = "Shovel[#{@name}]" | |||
| @tag = "Shovel-#{Random::Secure.urlsafe_base64(24)}" | |||
There was a problem hiding this comment.
I don't know what this adds, afaik this is never logged anywhere. The name of the receiving queue would make more sense. Else, just shovel.
There was a problem hiding this comment.
Yeah, you're right. I was thinking we wanted to keep consumer tags unique, but I guess that doesn't matter here since they are always on their own channel.
carlhoerberg
approved these changes
Feb 12, 2024
viktorerlingsson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Sets consumer tag for shovels to just
shovelinstead of using the shovel name, since that could be longer than 255 characters.Based on discussion in #627
HOW can this pull request be tested?
Run spec