Configurable default user & password #919
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt user and password is set after specs have run, remove spec for env variables since it does not work
…t default user and password is set after specs have run, remove spec for env variables since it does not work
spuun
reviewed
Feb 4, 2025
| when "tls_key" then @tls_key_path = v | ||
| when "tls_ciphers" then @tls_ciphers = v | ||
| when "tls_min_version" then @tls_min_version = v | ||
| when "default_user_only_loopback" then @default_user_only_loopback = true?(v) |
There was a problem hiding this comment.
What about still supporting guest_only_loopback but log a warning if it's used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Makes it possible to configure default user and password. Takes a hashed value for password.
Also adds api endpoint
/api/auth/hash_password/:passwordand lavinmqctl commandlavinmqctl hash_password passwordto hash passwords.Also changes
guest-only-loopbacktodefault-user-only-loopback, since the default user no longer has to beguest.Fixes #877
Configuration
Values can be configured by environment variables, in the config file or by command line arguments.
Env
Config file
Command line
--default-user=USER --default-password=PASSWORDHOW can this pull request be tested?
Run specs.