Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create empty markdown blocks #1334

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Don't create empty markdown blocks #1334

merged 1 commit into from
Mar 11, 2025

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.71.0-1-g52206b2
Number of rules parsed 7
Number of rules checked 7
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   37.21m ± 6%   37.20m ± 2%       ~ (p=1.000 n=10)
CheckRules-4     8.437 ± 2%    8.502 ± 2%       ~ (p=0.123 n=10)
geomean         560.3m        562.4m       +0.37%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   29.20Mi ± 0%   29.20Mi ± 0%       ~ (p=0.971 n=10)
CheckRules-4    988.7Mi ± 0%   988.6Mi ± 0%       ~ (p=0.631 n=10)
geomean         169.9Mi        169.9Mi       -0.01%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   136.0k ± 0%   136.0k ± 0%       ~ (p=0.646 n=10)
CheckRules-4    14.37M ± 0%   14.36M ± 0%       ~ (p=0.393 n=10)
geomean         1.398M        1.397M       -0.01%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.62%. Comparing base (92ea8bf) to head (52206b2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1334   +/-   ##
=======================================
  Coverage   95.62%   95.62%           
=======================================
  Files         108      108           
  Lines       14230    14230           
=======================================
  Hits        13608    13608           
  Misses        469      469           
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@prymitive prymitive merged commit 61d40b6 into main Mar 11, 2025
20 checks passed
@prymitive prymitive deleted the problems branch March 11, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants