Expose issuer as a worker service binding #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibmeu
reviewed
Feb 10, 2025
src/index.ts
Outdated
| } | ||
| // If we move the rotation logic to a separate worker, we can define a rotation-specific named entry point. | ||
| // https://developers.cloudflare.com/workers/runtime-apis/bindings/service-bindings/rpc/ | ||
| export class IssuerHandler extends WorkerEntrypoint<Bindings> { |
There was a problem hiding this comment.
from a review perspective, it could be worth keeping the methods unchanged (not moving them to a new class)
and declare the new class Issuer below which would proxy method, possibly with different method signatures. for instance, I could imagine handleTokenRequest to be have the following signature issue(request: TokenRequest)
ctx is also specific to this worker, that is hard to provide from another worker.
lbaquerofierro
force-pushed
the
lina/PCP-299
branch
from
b41cbf0 to
4c42a25
Compare
thibmeu
reviewed
Feb 11, 2025
.gitignore
Outdated
Comment on lines
1
to
2
| dist/* | ||
| !dist/types/ |
There was a problem hiding this comment.
why publish the dist folder? is this required for use as a submodule?
lbaquerofierro
force-pushed
the
lina/PCP-299
branch
23 times, most recently
from
8219242 to
7075db4
Compare
lbaquerofierro
force-pushed
the
lina/PCP-299
branch
3 times, most recently
from
1d1a13a to
3c92805
Compare
lbaquerofierro
force-pushed
the
lina/PCP-299
branch
5 times, most recently
from
957a513 to
89e6fe0
Compare
lbaquerofierro
force-pushed
the
lina/PCP-299
branch
from
89e6fe0 to
4f3f256
Compare
lbaquerofierro
force-pushed
the
lina/PCP-299
branch
12 times, most recently
from
f88c16b to
e4e8c0c
Compare
lbaquerofierro
force-pushed
the
lina/PCP-299
branch
from
e4e8c0c to
ee2e11d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.