Add support for batched token requests in privacypass-issuer #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Just not sure about the indentation (tabs or spaces). |
thibmeu
reviewed
Mar 6, 2025
src/index.ts
Outdated
Comment on lines
174
to
171
| // name: ctx.isTest() ? 'RSA-PSS' : 'RSA-RAW', | ||
| // RSA-RAW is handled directlry by blindrsa-tsst() | ||
| // https://github.com/cloudflare/blindrsa-ts/blob/64dc207f079ca680d4db6cd5a22f5bce6f1b28e8/src/blindrsa.ts#L168 | ||
| name: 'RSA-PSS', |
There was a problem hiding this comment.
this should not change
you should consider adding the importKey mock for the test, as is done on cloudflare/privacypass-ts
lbaquerofierro
force-pushed
the
arbitrary_batched_toknes
branch
4 times, most recently
from
321d396 to
2a7d82a
Compare
lbaquerofierro
force-pushed
the
arbitrary_batched_toknes
branch
from
2a7d82a to
c632a40
Compare
This upgrades privacypass-ts to the latest version, and updates tests accordingly
…rbitrary_batched_toknes
lbaquerofierro
force-pushed
the
arbitrary_batched_toknes
branch
4 times, most recently
from
cb6889f to
3912840
Compare
lbaquerofierro
force-pushed
the
arbitrary_batched_toknes
branch
from
3912840 to
18c7e8f
Compare
armfazh
reviewed
Mar 10, 2025
| const client = new Client(BlindRSAMode.PSS); | ||
| export async function testE2E(issuerName: string, nTokens: number, mTLS?: MTLSConfiguration): Promise<boolean> { | ||
| return nTokens > 1 | ||
| ? testArbitraryBatchedRequest(issuerName, nTokens, mTLS) |
There was a problem hiding this comment.
test must be split in two cases based on the type of token, not on the number of tokens requested.
Note that it's valid to perform a batchedTokenRequest with 0, 1, or more tokens.
| 'verify', | ||
| ]); | ||
| } | ||
| const MODE = BlindRSAMode.PSS; |
There was a problem hiding this comment.
this is used only once, better to remove MODE
armfazh
reviewed
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several updates and improvements to the
privacypass-issuerproject. Key changes include:InvalidContentTypeErrorandMismatchedTokenKeyIDErrorto handle specific error scenarios.handleTokenRequestto handle different content types (PRIVATE_TOKEN_REQUESTandARBITRARY_BATCHED_TOKEN_REQUEST).handleSingleTokenRequestfor single token issuance.handleBatchedTokenRequestfor batched token issuance, including validation and key-pair retrieval.getBlindRSAKeyPairto handle key retrieval and error logging.index.test.tsto verify the handling of batched token requests.e2e/issuer.tsto verify handling of batched token requests in a deployed worker.- Updated
testCommandine2e/index.tsto accept the number of tokens for testing.--tokensoption to specify the number of tokens to use in tests.