Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ffi / c functions to be able to send packets to a specific path #1662

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

normanmaurer
Copy link
Contributor

Motivation:

Quiche provides mutliple methods that allows to send packets on a specific path. These were not exposed in the C api.

Modifications:

  • Add missing functions to the c API

Result:

Be able to send packets on a specific path

@normanmaurer normanmaurer requested a review from a team as a code owner November 22, 2023 08:05
@normanmaurer normanmaurer changed the title Add ffi / c functions to handle path Add ffi / c functions to be able to send packets to a specific path Nov 22, 2023
@normanmaurer normanmaurer force-pushed the path branch 4 times, most recently from fc4d11f to a385cb2 Compare November 22, 2023 11:18
@normanmaurer normanmaurer requested a review from LPardue November 23, 2023 19:46
Copy link
Contributor

@LPardue LPardue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

quiche/include/quiche.h Outdated Show resolved Hide resolved
quiche/include/quiche.h Outdated Show resolved Hide resolved
quiche/include/quiche.h Outdated Show resolved Hide resolved
@normanmaurer
Copy link
Contributor Author

rebased

Copy link
Member

@ghedo ghedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but added some minor nits.

quiche/include/quiche.h Outdated Show resolved Hide resolved
quiche/src/ffi.rs Show resolved Hide resolved
quiche/src/ffi.rs Outdated Show resolved Hide resolved
quiche/src/ffi.rs Outdated Show resolved Hide resolved
@normanmaurer normanmaurer force-pushed the path branch 2 times, most recently from c3f4edf to bdee221 Compare November 27, 2023 14:21
Motivation:

Quiche provides mutliple methods that allows to send packets on a specific path. These were not exposed in the C api.

Modifications:

- Add missing functions to the c API

Result:

Be able to send packets on a specific path

Co-authored-by: Alessandro Ghedini <alessandro@ghedini.me>
@ghedo ghedo merged commit f8ec4d4 into cloudflare:master Nov 27, 2023
24 checks passed
@normanmaurer normanmaurer deleted the path branch December 8, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants