feat(qlog): extend From<EventType> for EventImportance
#1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend `impl From<EventType> for EventImportance` for all `TransportEventType` `enum` variants.
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Dec 10, 2023
This commit adds support for the qlog [`version_information` QUIC event](https://quicwg.org/qlog/draft-ietf-quic-qlog-quic-events.html#name-version_information) on the client. Depends on mozilla#1504 Depends on cloudflare/quiche#1684 Meta issue: mozilla#528
|
The build failures were due to formatting lint (you can use |
LPardue
approved these changes
Dec 13, 2023
|
Merged as 12eebf3, thanks! |
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Dec 20, 2023
With cloudflare/quiche#1684 merged, one can use cloudflare's repo.
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Dec 27, 2023
This commit adds support for the qlog [`version_information` QUIC event](https://quicwg.org/qlog/draft-ietf-quic-qlog-quic-events.html#name-version_information) on the server. Depends on cloudflare/quiche#1684 Meta issue: mozilla#528
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Dec 27, 2023
This commit adds support for the qlog [`version_information` QUIC event](https://quicwg.org/qlog/draft-ietf-quic-qlog-quic-events.html#name-version_information) on the server. Depends on cloudflare/quiche#1684 Meta issue: mozilla#528
|
@LPardue could you release |
martinthomson
pushed a commit
to mozilla/neqo
that referenced
this pull request
Jan 11, 2024
* deps(qlog): update to qlog v0.10.0 This commit upgrades all `neqo-*` crates to use `qlog` `v0.10.0`. See also `qlog` `v0.10.0` release pull request cloudflare/quiche#1647 * feat(qlog): log version_information on client This commit adds support for the qlog [`version_information` QUIC event](https://quicwg.org/qlog/draft-ietf-quic-qlog-quic-events.html#name-version_information) on the client. Depends on #1504 Depends on cloudflare/quiche#1684 Meta issue: #528 * Use replace github.com/cloudflare with github.com/mxinden With cloudflare/quiche#1684 merged, one can use cloudflare's repo. * Inline ev_data * Remove crates.io patch Patch no longer needed since upgrade to neqo v0.11.0 #1547.
martinthomson
pushed a commit
to mozilla/neqo
that referenced
this pull request
Jan 16, 2024
* feat(qlog): log version_information on server This commit adds support for the qlog [`version_information` QUIC event](https://quicwg.org/qlog/draft-ietf-quic-qlog-quic-events.html#name-version_information) on the server. Depends on cloudflare/quiche#1684 Meta issue: #528 * Use WireVersion for client version * Have create_qlog_trace take &ConnectionIdRef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
impl From<EventType> for EventImportancefor allTransportEventTypeenumvariants.