ffi: quiche_conn_close and quiche_conn_stream_send check for null pointers (fix #1914) #1916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions
quiche_conn_close
andquiche_conn_stream_send
now check to make sure the passed pointers are not null before creating a slice with them. If they are null,&[]
is used instead. Length must be 0 when the buffer is null, of course.client.c
panics onquiche_conn_close
becausereason
isNULL
#1914.quiche_conn_stream_send
for convenience to trigger FIN STREAM.