Add release property validation #2602
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Releases can add a properties_schema.json file at the root of their jobs that is a json schema file. This schema will be used to validate deployment properties prior to template rendering during a deploy.
jpalermo
force-pushed
the
pr-add-property-schema-validation
branch
from
17fc797 to
8729145
Compare
beyhan
requested review from
a team,
mingxiao and
rajathagasthya
and removed request for
a team
aramprice
reviewed
Feb 7, 2025
Comment on lines
+42
to
+44
| if File.exist?(File.join(template_dir, 'properties_schema.json')) | ||
| properties_schema = JSON.load_file(File.join(template_dir, 'properties_schema.json')) | ||
| else |
There was a problem hiding this comment.
It would be great to start a trend of moving magic strings like 'properties_schema.json' into constants.
aramprice
reviewed
Feb 7, 2025
| return true if instance == "" | ||
| begin | ||
| OpenSSL::X509::Certificate.load(instance) | ||
| rescue OpenSSL::X509::CertificateError => e |
There was a problem hiding this comment.
Should => e be dropped here, or is that something we want to log, or otherwise capture?
There was a problem hiding this comment.
👍 don't think there is much in the way of valuable output here since it just "couldn't parse the cert", I think this was just muscle memory when typing rescue, removed now.
aramprice
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releases can add a properties_schema.json file at the root of their jobs that is a json schema file.
This schema will be used to validate deployment properties prior to template rendering during a deploy.
The new integration test won't pass until a new bosh-cli is cut with 681