Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove SQLx crate from torii-core #10

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

cmackenzie1
Copy link
Owner

This commit removes the sqlx crate from torii-core and removes the Error variant Database. Storages crates should use Storage variant instead.

I also moved the OAuthStorage trait out of torii-storage-sqlite and into torii-core to match the same structure as torii-auth-email

This commit removes the `sqlx` crate from `torii-core` and removes the Error variant `Database`. Storages crates should use `Storage` variant instead.

I also moved the `OAuthStorage` trait out of `torii-storage-sqlite` and into `torii-core` to match the same structure as `torii-auth-email`
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 57.56098% with 87 lines in your changes missing coverage. Please review.

Project coverage is 68.78%. Comparing base (dde8ee1) to head (368490e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
torii-storage-sqlite/src/lib.rs 44.59% 82 Missing ⚠️
torii-auth-oauth/src/lib.rs 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   69.60%   68.78%   -0.82%     
==========================================
  Files          11       11              
  Lines        1622     1746     +124     
==========================================
+ Hits         1129     1201      +72     
- Misses        493      545      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmackenzie1 cmackenzie1 merged commit b40e8d2 into main Feb 17, 2025
1 of 3 checks passed
@cmackenzie1 cmackenzie1 deleted the cole/sqlite-user branch February 17, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant