Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add PostgreSQL storage implementation for Torii #11

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

cmackenzie1
Copy link
Owner

This commit introduces a PostgreSQL storage implementation for Torii. Adding this implementation highlighted an issue around nulls that wasn't caught by the sqlite implementation since it is flexible with types.

This crate requires docker compose up -d to be run (or a postgres instance to be available) for the tests to run.

Closes #3

This commit introduces a PostgreSQL storage implementation for Torii. Adding this implementation highlighted an issue around nulls that wasn't caught by the sqlite implementation since it is flexible with types.

This crate requires `docker compose up -d` to be run (or a postgres instance to be available) for the tests to run.

Closes #3
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 55.84192% with 257 lines in your changes missing coverage. Please review.

Project coverage is 65.57%. Comparing base (b40e8d2) to head (eefaf93).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
torii-storage-postgres/src/lib.rs 55.93% 256 Missing ⚠️
torii-core/src/plugin.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   68.78%   65.57%   -3.21%     
==========================================
  Files          11       12       +1     
  Lines        1746     2327     +581     
==========================================
+ Hits         1201     1526     +325     
- Misses        545      801     +256     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmackenzie1 cmackenzie1 merged commit b988cc9 into main Feb 18, 2025
1 of 3 checks passed
@cmackenzie1 cmackenzie1 deleted the postgres branch February 18, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add torii-storage-postgres
1 participant