feat: Add session cleanup, use ID type consistently, support password changes #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces background task for periodic session cleanup with configurable intervals and max session age. Extends SessionStorage trait with a new method to remove expired sessions, and adds a default configuration for session cleanup. Includes tests to verify the cleanup process works as expected.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 70.37% 75.63% +5.26%
==========================================
Files 9 9
Lines 1259 1568 +309
==========================================
+ Hits 886 1186 +300
- Misses 373 382 +9 ☔ View full report in Codecov by Sentry. |
This commit updates various storage methods to use strongly typed `UserId` and `SessionId` instead of string references. The changes include: - Modifying method signatures in storage traits to accept `&UserId` and `&SessionId` - Updating implementations across different modules to use the new ID types - Adjusting method calls to use `.id` or `SessionId::new()` where necessary - Ensuring consistent ID handling throughout the authentication and storage layers
cmackenzie1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces background task for periodic session cleanup with configurable intervals and max session age. Extends SessionStorage trait with a new method to remove expired sessions, and adds a default configuration for session cleanup. Includes tests to verify the cleanup process works as expected.