Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EFM normalization button (#503) #504

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

Paulocracy
Copy link
Member

No description provided.

@Paulocracy Paulocracy added the enhancement New feature or request label Feb 1, 2024
@Paulocracy Paulocracy self-assigned this Feb 1, 2024
@axelvonkamp
Copy link
Member

Usually one would like the normalization to be applied to all modes at once and not only to the one on display.

@Paulocracy
Copy link
Member Author

@axelvonkamp You're right, look at my new solution attempt which applies the normalization to all EFMs.

@axelvonkamp
Copy link
Member

This works, but if you save the modes after normalization and load them later they will be unchanged which might be confusing, but this is perhaps not a big deal.
Also, the mode_normalization_reaction should be reset when the mode navigator is being closed.

axelvonkamp
axelvonkamp previously approved these changes Feb 28, 2024
@Paulocracy Paulocracy merged commit 145ce92 into master Feb 28, 2024
4 checks passed
@Paulocracy Paulocracy deleted the normalization_button branch February 28, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants