Push to Python 3.10 #514
Merged
Push to Python 3.10 #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelvonkamp
approved these changes
Jun 27, 2024
sthiele
reviewed
Jun 27, 2024
There was a problem hiding this comment.
The proposed changes look good to me. Besides that I noticed some unused import in the files and probably in others as well. Also I think type annotation has changed in Python. https://docs.python.org/3/library/typing.html
I also noticed a quirk with the use scenario checkbox, but I'm not sure it is related to this PR.
|
Oh yes, type annotations are now much easier to do as, most of the times, one does not need to import typing anymore; As you suggested, deleting (now) unused imports is a primary target now :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release contains Qt call fixes and a refurbished environment to make CNApy compatible with Python 3.10. Accordingly, to test this PR, you have to create a new mamba/conda environment from the YML file.