Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc analysis criteria #286

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dwelsch-esi
Copy link
Collaborator

Update criteria to include common findings from the last two years of CNCF doc analyses.

@nate-double-u
Copy link
Member

Thanks for this @dwelsch-esi, I've removed the analyses/0014-vitess/vitess-analysis.md file because i think it was probably mistakenly included from #284.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates @dwelsch-esi. See inline for a few initial comments. I'll provide more later, but could you first rebase from main at HEAD, and ensure that all checks are passing?

named according to user goals?)
We evaluate on the following:

- Is there high level conceptual/“About” content?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid using using "about":

Suggested change
- Is there high level conceptual/“About” content?
- Is there high level conceptual content?

Comment on lines +21 to +22
- Is the documentation feature-complete? (i.e., every product feature is
documented)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Is the documentation feature-complete? (i.e., every product feature is
documented)
- Is every product feature documented?

dwelsch-esi and others added 3 commits February 25, 2025 14:08
Signed-off-by: Dave Welsch <dwelsch@expertsupport.com>
… CNCF doc analyses.

Signed-off-by: Dave Welsch <dwelsch@expertsupport.com>
Signed-off-by: Nate W <natew@cncf.io>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Comment on lines +223 to +233
We evaluate on the following:

- Incubating: Are all [website guidelines][] satisfied? Graduated: Are all
guidelines satisfied?
- Incubating: Was a [docs assessment][] requested through CNCF service desk?
Graduated: All follow-up actions addressed?
- Incubating: User roles identified and doc needs documented? Graduated: All
stakeholder need identified?
- Incubating: Website hosted directly? Graduated: Hosted directly?
- Incubating: Is the [docs assessment][] comprehensive, addressing most
stakeholder needs? Graduated: Fully addresses needs of key stakeholders?
Copy link
Collaborator

@chalin chalin Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the breakdown that we had before. At a minimum, can you organize it in a list, with the first-level list items are maturity levels like we had before?

@nate-double-u WDYT?

### Minimal website requirements

Listed here are the _minimal_ website requirements for projects based on their
[maturity level][]: sandbox, incubating, graduated and archived.
[maturity level]: sandbox, incubating, graduated and archived.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the trailing [], it helps tools like VS Code know that this is, for sure, a markdown link reference:

Suggested change
[maturity level]: sandbox, incubating, graduated and archived.
[maturity level][]: sandbox, incubating, graduated and archived.

Comment on lines +264 to +266
Plan for suitable [accessibility] measures for your website. For example:

We evaluate on the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-paste error here? It doesn't make sense to have two phrases ending in colons. Maybe you meant:

Suggested change
Plan for suitable [accessibility] measures for your website. For example:
We evaluate on the following:
Plan for suitable [accessibility][] measures for your website. For example, we
evaluate on the following:

@@ -329,3 +351,4 @@ Example:

- Is your website accessible via HTTPS?
- Does HTTP access, if any, redirect to HTTPS?
- Are links to external websites or applications working and current?
Copy link
Collaborator

@chalin chalin Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition! Actually, we want to know if links (be they internal or external) are valid.

@chalin
Copy link
Collaborator

chalin commented Feb 25, 2025

Hurray, file format and link checking are passing! We can address the markdown linter issues after the other prose comments have been addressed IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants