Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update packages and run checks and fixes #287

Merged

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Feb 25, 2025

@chalin chalin added the CI/infra CI & infrastructure label Feb 25, 2025
@chalin chalin requested a review from nate-double-u February 25, 2025 15:40
@chalin chalin force-pushed the chalin-im-rw-update-pkgs-run-checks-2025-02-25 branch from 4192f8c to 3cc2aa5 Compare February 25, 2025 15:41
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Patrice!

@chalin
Copy link
Collaborator Author

chalin commented Feb 25, 2025

Any idea why it's taking so long for the checks to run?

@nate-double-u
Copy link
Member

I was wondering that myself

Signed-off-by: Patrice Chalin <pchalin@gmail.com>
@chalin chalin force-pushed the chalin-im-rw-update-pkgs-run-checks-2025-02-25 branch from 3cc2aa5 to 6dc4631 Compare February 25, 2025 16:38
@chalin
Copy link
Collaborator Author

chalin commented Feb 25, 2025

For the record, there's a bug in the 3.13.x stream of the link checker:

So we'll pin the package to 3.12.x until that get's fixed.

Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
@chalin
Copy link
Collaborator Author

chalin commented Feb 25, 2025

Thanks for the review @nate-double-u. Merging now. I'll address the link-check failures in a followup PR.

@chalin chalin merged commit ac83b89 into cncf:main Feb 25, 2025
4 of 5 checks passed
@chalin chalin deleted the chalin-im-rw-update-pkgs-run-checks-2025-02-25 branch February 25, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants