feat: update playwright DOWNLOAD_PATHS #751
Conversation
WalkthroughThis PR expands the supported platforms by updating the DOWNLOAD_PATHS constant and associated configurations. It adds new platform entries (ubuntu24.04-x64, ubuntu24.04-arm64, mac15, mac15-arm64) for several browsers, introduces a new browser type ("winldd"), and consolidates headless shell logic within the fetch method. Test cases have been adjusted to reflect these changes, and the JSON fixture for browser configuration has been updated with new revision numbers and version strings. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant F as fetch()
participant C as DOWNLOAD_PATHS
U->>F: Request browser binary configuration
F->>C: Lookup configuration for requested browser type
alt Headless-shell variant requested
F->>C: Check for "chromium-tip-of-tree-headless-shell"
alt Found
F->>U: Return headless-shell configuration
else
F->>C: Copy properties from "chromium-tip-of-tree"
F->>U: Return updated configuration
end
else
F->>U: Return standard configuration (including new "winldd" if applicable)
end
Assessment against linked issues
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms (10)
🔇 Additional comments (13)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #751 +/- ##
========================================
Coverage 96.42% 96.42%
========================================
Files 191 191
Lines 19132 19232 +100
Branches 2504 2503 -1
========================================
+ Hits 18448 18545 +97
- Misses 684 687 +3 ☔ View full report in Codecov by Sentry. |
[skip ci] ## [3.73.0](v3.72.1...v3.73.0) (2025-02-07) ### Features * update playwright DOWNLOAD_PATHS ([#751](#751)) ([1850c8b](1850c8b))
closes #750
Summary by CodeRabbit