-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add concurrency and retry options #478
base: 6.x
Are you sure you want to change the base?
Conversation
barretlee
commented
Feb 27, 2025
- add options.concurrency
- add options.retry
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
7740ad4
to
db5cab0
Compare
@@ -296,6 +298,9 @@ debug('argv: %j, env: %j', argv, env); | |||
config.trace = argv.trace; | |||
config.engineStrict = argv['engine-strict']; | |||
config.registryOnly = argv['registry-only']; | |||
config.concurrency = process.env.concurrency || argv.concurrency; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
process.env.concurrency
and process.env.retry
are not needed and can be removed, as they are currently passed in as CLI parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里南取特意提醒我加上去的,因为 tnpm 是 fork 的 npminstall 进程,cli 传参传不进去,env 传参会更加方便、合适。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
那可能需要设置一下环境变量前缀,如 NPMINSTALL_CONCURRENCY
这样,要不然 concurrency 太通用了