Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCAP-672] - implement registration-submit-confirmation screen and code cleanup #1221

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

analoo
Copy link
Contributor

@analoo analoo commented Feb 26, 2025

🔗 Jira ticket

CCAP-672

✍️ Description

  • removed references to submit-confirmation since it was dead
  • cleaned up some typos in screens
  • created a survey question template since options are always the same
  • created the registration-submit-confirmation screen

📷 Design reference

Design is inconsistent in how data is displayed on the screen so used design that mirrors what is in family submission
Registration Submit Screen After Feedback has been Submitted and Before
Screenshot 2025-02-26 at 4 07 44 PM
Screenshot 2025-02-26 at 4 09 11 PM

Complete Submit Screen from GCC before and after feedback is submitted
Screenshot 2025-02-26 at 4 06 30 PM
Screenshot 2025-02-26 at 4 05 26 PM

✅ Completion tasks

  • Added relevant tests
  • Meets acceptance criteria

@@ -429,10 +429,6 @@ flow:
submit-next-steps:
nextScreens:
- name: complete-submit-confirmation
submit-confirmation:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a dead page, nothing was pointing at it except itself

@@ -0,0 +1,30 @@
<th:block th:fragment="surveyQuestion"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teeny tiny change. Moved the survey question to its own fragment

@@ -31,6 +31,4 @@
</div>
<th:block th:replace="~{fragments/footer :: footer}"/>
</body>
</html>

cfa:ye
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny mistakes from the past :(

@enyia21 enyia21 temporarily deployed to il-gcc-ccap-672-registr-mb0pgx February 27, 2025 00:01 Inactive
@analoo analoo changed the title remove references to submit-confirmation screen, cleanup code and iml… [CCAP-672] - implement registratio-submit-confirmation screen and code cleanup Feb 27, 2025
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-672-registr-mb0pgx February 27, 2025 00:09 Inactive
@analoo analoo changed the title [CCAP-672] - implement registratio-submit-confirmation screen and code cleanup [CCAP-672] - implement registratio,-submit-confirmation screen and code cleanup Feb 27, 2025
@analoo analoo changed the title [CCAP-672] - implement registratio,-submit-confirmation screen and code cleanup [CCAP-672] - implement registration-submit-confirmation screen and code cleanup Feb 27, 2025
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-672-registr-mb0pgx February 27, 2025 00:32 Inactive
@analoo analoo merged commit f3c6670 into main Feb 27, 2025
5 checks passed
@analoo analoo deleted the CCAP-672-registration-submit-confirmation-screen branch February 27, 2025 21:41
enyia21 pushed a commit that referenced this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants