Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCAP-677] Removing old email code and using the new methods #1223

Merged
merged 7 commits into from
Feb 28, 2025

Conversation

cram-cfa
Copy link
Contributor

@cram-cfa cram-cfa commented Feb 27, 2025

πŸ”— Jira ticket

✍️ Description

Sample of the Family Confirmation Email from The Family Flow
Screenshot 2025-02-27 at 5 22 11β€―PM
Sample of the family confirmation email when the provider agrees to care
Screenshot 2025-02-27 at 4 36 38β€―PM

πŸ“· Design reference

βœ… Completion tasks

  • Added relevant tests
  • Meets acceptance criteria

@cram-cfa cram-cfa requested a review from analoo February 27, 2025 15:53
@github-actions github-actions bot requested a review from enyia21 February 27, 2025 15:53
@enyia21 enyia21 temporarily deployed to il-gcc-marc-ccap-677-4r1fylcm3 February 27, 2025 15:55 Inactive
Copy link
Contributor

@enyia21 enyia21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

analoo
analoo previously requested changes Feb 27, 2025
Copy link
Contributor

@analoo analoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few changes that can be made to this PR but I will handle them.

@enyia21 enyia21 temporarily deployed to il-gcc-marc-ccap-677-4r1fylcm3 February 28, 2025 01:38 Inactive
@enyia21 enyia21 temporarily deployed to il-gcc-marc-ccap-677-4r1fylcm3 February 28, 2025 01:53 Inactive
@enyia21 enyia21 temporarily deployed to il-gcc-marc-ccap-677-4r1fylcm3 February 28, 2025 01:54 Inactive
@enyia21 enyia21 temporarily deployed to il-gcc-marc-ccap-677-4r1fylcm3 February 28, 2025 01:56 Inactive
@analoo analoo requested a review from enyia21 February 28, 2025 01:57
@cram-cfa
Copy link
Contributor Author

LGTM @analoo but you've got a merge conflict.

@cram-cfa
Copy link
Contributor Author

I think, once this is merged in, @analoo you should do some testing on Staging before asking Carl to retest all the email paths that he's been testing.

Just make sure that you actually get all 3 emails -- two family emails, one provider email -- and that nothing weird is happening.

@enyia21 enyia21 temporarily deployed to il-gcc-marc-ccap-677-4r1fylcm3 February 28, 2025 17:34 Inactive
@analoo analoo self-requested a review February 28, 2025 17:37
@enyia21 enyia21 temporarily deployed to il-gcc-marc-ccap-677-4r1fylcm3 February 28, 2025 17:38 Inactive
@analoo analoo dismissed their stale review February 28, 2025 17:38

addressed

…CCAP-677 (#1231)

Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
@enyia21 enyia21 temporarily deployed to il-gcc-marc-ccap-677-4r1fylcm3 February 28, 2025 19:53 Inactive
@analoo analoo merged commit 2d77b0d into main Feb 28, 2025
5 checks passed
@analoo analoo deleted the marc-CCAP-677 branch February 28, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants