[CCAP-357] Make the confirmation code input readonly #1225
Merged
+12
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed. |
enyia21
requested changes
Feb 27, 2025
| @@ -391,7 +389,7 @@ void LicenseExemptInProviderHomeFlow() { | |||
| } | |||
|
|
|||
| @Test | |||
| void LicenseExemptInChildHomeFlow() { | |||
| void licenseExemptInChildHomeFlow() { | |||
There was a problem hiding this comment.
So why are making our test methods lower case?
There was a problem hiding this comment.
Because the Java naming convention for methods is camelCase, and it has annoyed me that we don't follow that in our tests consistently. So I figured since I was in here and it was annoying me, I'd change it for this class.
(And eventually I'll change them all in other classes in the middle of the night when I get bored enough :) )
enyia21
approved these changes
Feb 27, 2025
analoo
reviewed
Feb 27, 2025
analoo
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Jira ticket
✍️ Description
📷 Design reference
✅ Completion tasks