Skip to content

Commit

Permalink
Cr 16999 (#673)
Browse files Browse the repository at this point in the history
* add skip-permissions-validation flag and auto skip for fine-grained token

* fix bbs validate check

* if using new fine-grained token throw and error to use skip permission flag

* if using new fine-grained token throw and error to use skip permission flag

* bump

* wip

* auto skip permissions validation for upgrade and uninstall

* auto skip permissions validation for upgrade and uninstall

* mark flag hidden

* bump

* resolve conflicts

* expose skip-permissions-validation flag

* expose skip-permissions-validation flag

* trigger
  • Loading branch information
kim-codefresh authored Feb 14, 2023
1 parent 05bc518 commit 0d56520
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
VERSION=v0.1.31
VERSION=v0.1.32

OUT_DIR=dist
YEAR?=$(shell date +"%Y")
Expand Down
1 change: 0 additions & 1 deletion cmd/commands/runtime_install.go
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,6 @@ func NewRuntimeInstallCommand() *cobra.Command {
util.Die(cmd.Flags().MarkHidden("ips-allow-list"))
util.Die(cmd.Flags().MarkHidden("runtime-def"))
util.Die(cmd.Flags().MarkHidden("set-default-resources"))
util.Die(cmd.Flags().MarkHidden("skip-permissions-validation"))
cmd.MarkFlagsMutuallyExclusive("runtime-def", "version")
cmd.MarkFlagsMutuallyExclusive("runtime-def", "set-default-resources")

Expand Down
1 change: 1 addition & 0 deletions docs/commands/cli-v2_runtime_install.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ cli-v2 runtime install [runtime_name] [flags]
--shared-config-repo string URL to the shared configurations repo. (default: <installation-repo> or the existing one for this account)
--skip-cluster-checks Skips the cluster's checks
--skip-ingress Skips the creation of ingress resources
--skip-permissions-validation Skip personal access token permissions validation (default: false)
-b, --upsert-branch If true will try to checkout the specified branch and create it if it doesn't exist
--version string The runtime version to install (default: stable)
--wait-timeout duration How long to wait for the runtime components to be ready (default 8m0s)
Expand Down

0 comments on commit 0d56520

Please sign in to comment.