Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snow issue402 #404

Merged
merged 38 commits into from
Oct 14, 2021
Merged

Snow issue402 #404

merged 38 commits into from
Oct 14, 2021

Conversation

lrochette
Copy link
Contributor

This is a big set of changes:

  • Add an action to close a CR in serviceNow plugins #402: introduce closeCR action to close an existing CR
  • added updateCR action to modify an existing CR (same API than close but with different body basically)
  • URL to the CR created now shows up on the creation step
  • more error checks about expected values
  • sample in the step.yaml updated
  • Breaking changes: parameters have been renamed to:
    • be all uppercase
    • have CR_ (or SN_) prefix for consistency

@lrochette
bumping version to force rebuild
c81de76
@lrochette
Change to private account
08a449b
@lrochette
#402: Adding logic for action
22ee7b4
@lrochette
#402: fix step.yaml syntax
43c196a
@lrochette
#402: smaller SVG icon
2c1bc1e
@lrochette
402: new smaller logo in svg format
962e26b
@lrochette
#402: adding code for closing CR
e52613a
@lrochette
: use all CAPS for parameters to get consistency
36d4e2e
@lrochette
#402: Fixing python script
ba7283d 
Adding code for modifying a CR as well
@lrochette
#402: test for empty CR_DATA
4be688e
@lrochette
#402: test for empty CR_DATA
d38a408
@lrochette
#402: test for empty CR_DATA
6ee91cd
@lrochette
#402: test for empty CR_DATA
ba322bd
@lrochette
#402: step.yaml syntax?
46052e9
@lrochette
#402: remvoing blank lines
21c4cee
@lrochette
#402: fix go template syntax with eq instead of ==
f771571
@lrochette
#402: fix conflict between CR_ACTION to the step and ACTION to the sc…
76745a0 
…ript
@lrochette
more debug info
cf4ef11
@lrochette
#402: more debug info
51f83dd
@lrochette
#402: push overwrite of env variable to the end of the block
10087b3
@lrochette
#402: minor debug info fixes
3b8f642
@lrochette
#402: change DEBUG to boolean
bf26d37
@lrochette
#402: change DEBUG to boolean
ce6ce30
@lrochette
#402: debug info on action
6afd91b
@lrochette
#402: debug info on action
78cce4e
@lrochette
#402: debug info on action
e4593af
@lrochette
#402: debug info on action
99827b2
@lrochette
#402: debug info
2208a02
@lrochette
: exit with non-zero on error
a8466a4
@lrochette
: exit with non-zero on error
887cf6f
TedSpinks
TedSpinks approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@TedSpinks TedSpinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big one! I noted a couple things to change.

@lrochette
#402: Ted notes
5ffc72a 
remove venonalog.json
Fix branch name for icon
Fix first line
@lrochette
Ted notes
d552461
@lrochette lrochette merged commit c1769f0 into master Oct 14, 2021
@lrochette lrochette deleted the snow-issue402 branch October 14, 2021 21:58
@dustinvanbuskirk
Copy link
Contributor

I tested the code itself and it all works great but I ran into issues pulling the examples from the step and using them. I've documented all of them in my review.

It looks like this was already shipped though 🤷

dustinvanbuskirk
dustinvanbuskirk reviewed Oct 14, 2021
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustinvanbuskirk dustinvanbuskirk dustinvanbuskirk left review comments

@TedSpinks TedSpinks TedSpinks approved these changes

@francisco-cocozza francisco-cocozza Awaiting requested review from francisco-cocozza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lrochette @dustinvanbuskirk @TedSpinks