-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: add Fedora 39 and openSUSE Tumbleweed based images #6669
Conversation
&& printf "user: coder\ngroup: coder\n" > /etc/fixuid/config.yml | ||
|
||
COPY ci/release-image/entrypoint.sh /usr/bin/entrypoint.sh | ||
RUN --mount=from=packages,src=/tmp,dst=/tmp/packages dnf install -y /tmp/packages/code-server*$(uname -m | sed 's/x86_64/amd64/g' | sed 's/aarch64/arm64/g').rpm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN --mount=from=packages,src=/tmp,dst=/tmp/packages dnf install -y /tmp/packages/code-server*$(uname -m | sed 's/x86_64/amd64/g' | sed 's/aarch64/arm64/g').rpm | |
RUN --mount=from=packages,src=/tmp,dst=/tmp/packages rpm -i /tmp/packages/code-server*$(uname -m | sed 's/x86_64/amd64/g' | sed 's/aarch64/arm64/g').rpm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review after CI passes and produces working images
The Docker publish flow runs when a release is made; I can trigger it manually but GitHub only lets me do it on branches directly on the main repo, so I temporarily pushed this to another branch and tested it there with success: https://github.com/coder/code-server/actions/runs/7835620384/job/21381406143. The resulting images have been published for v4.21.0 and appear to be working.
One weird thing is that both the dnf install
commands hung for a long while (around 20-30 minutes each) on the Fedora arm64 build. They eventually completed, but I am not sure if there is something we can improve here.
I am going ahead with the merge for now though, thank you!
Hm, had no issue on my aarch64 nodes (I actually started the development on aarch64), only slow due to downloads for me. I have to clean cache after each dnf call to ensure cache isn't in the layers and won't take space. Thanks for reviewing and merging! |
Fixes #6661
Please review after CI passes and produces working images