-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize ByteBufferFetcher, Prototype #1974
Conversation
@colinrtwhite |
coil-core/src/androidMain/kotlin/coil3/decode/StaticImageDecoderDecoder.kt
Show resolved
Hide resolved
coil-core/src/jvmCommonMain/kotlin/coil3/fetch/ByteBufferFetcher.kt
Outdated
Show resolved
Hide resolved
* Metadata containing the [bytebuffer] of a ByteBuffer, maybe direct | ||
*/ | ||
@ExperimentalCoilApi | ||
class ByteBufferMetadata( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file might have to be renamed to ImageSource.jvm.kt
to avoid class name conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it doesn't have top-level functions/field, so will not have clash.
@colinrtwhite
But I decided not to optimize it as I think one use ByteArray to decode would not care performance |
Close #1971
We will do following things in this CL