Fix skipped audio chunk #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f a segment Signed-off-by: makaveli10 <vineet.suryan@collabora.com>
makaveli10
force-pushed
the
fix_skipped_audio_chunk
branch
from
00346df to
182b5cb
Compare
zoq
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While incrementing the timestamp offset for the audio frames if a segment is repeated
nnumber of times we should ideally increment it by the end time of the first repitition of this segment otherwise it is possible that we include some of the audio from the next segment which is not yet transcribed and is lost forever.This PR records the end time of the first repitition and uses that to increment the timestamp offset if the number of repititions are more than the threshold.