Increase rust version from 1.70 to 1.73 (#63)

The zip crate has required at least 1.73 since 2.0.0

The more recent versions of the zip 1.x.x series have been yanked so
alternatively downgrading to 1.1.4 would allow CI to pass with toolchain
1.70.

This also resolves the complaints from the latest version of clippy.

It changes `Run::update` to return the `trace_update_interval` value,
the alternative would be removing it or tagging it as unused.

.github/workflows/ci.yml

@@ -18,7 +18,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@master # avoid the tag here to prevent dependabot from updating it
         with:
-            toolchain: "1.70"
+            toolchain: "1.73"
       - run: cargo check --all-targets --all-features
 
   fmt:
@@ -28,7 +28,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@master # avoid the tag here to prevent dependabot from updating it
         with:
-            toolchain: "1.70"
+            toolchain: "1.73"
             components: rustfmt
       - run: cargo fmt --all --check
 
@@ -39,7 +39,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@master # avoid the tag here to prevent dependabot from updating it
         with:
-            toolchain: "1.70"
+            toolchain: "1.73"
       - run: cargo test --all-targets --all-features
       - run: cargo test --doc
 
@@ -50,7 +50,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@master # avoid the tag here to prevent dependabot from updating it
         with:
-            toolchain: "1.70"
+            toolchain: "1.73"
             components: clippy
       - run: cargo clippy --all-targets --all-features -- -D warnings
 

gitlab-runner/Cargo.toml

@@ -21,7 +21,7 @@ serde = { version = "1.0.200", features = [ "derive" ] }
 serde_json = "1.0.64"
 thiserror = "1.0.59"
 bytes = "1.0.1"
-zip = "1.2.3"
+zip = "2.2.2"
 pin-project = "1.0.7"
 futures = "0.3.15"
 async-trait = "0.1.50"

gitlab-runner/src/client.rs

@@ -106,6 +106,10 @@ struct JobUpdate<'a> {
 
 #[derive(Debug, Clone)]
 pub struct JobUpdateReply {
+    // GitLabs job update endpoint can include a suggested request rate in the response's HTTP header.
+    // Currently we only use this value from trace calls (e.g. appending to the jobs log).
+    // This field is kept around to document it's existence.
+    #[allow(dead_code)]
     pub trace_update_interval: Option<Duration>,
 }
 

gitlab-runner/src/job.rs

@@ -63,7 +63,7 @@ pub struct Dependency<'a> {
     dependency: &'a JobDependency,
 }
 
-impl<'a> Dependency<'a> {
+impl Dependency<'_> {
     /// The id of the dependency
     ///
     /// This id matches the job id of the generated this depenency

gitlab-runner/src/uploader.rs

@@ -137,7 +137,7 @@ pub struct UploadFile<'a> {
     state: UploadFileState<'a>,
 }
 
-impl<'a> AsyncWrite for UploadFile<'a> {
+impl AsyncWrite for UploadFile<'_> {
     fn poll_write(
         self: std::pin::Pin<&mut Self>,
         cx: &mut std::task::Context<'_>,