Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unmaintained structopt with clap #73

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Replace unmaintained structopt with clap #73

merged 1 commit into from
Jan 20, 2025

Conversation

ColinKinloch
Copy link
Contributor

@ColinKinloch ColinKinloch commented Jan 17, 2025 •
edited
Loading

Use clap and clap_derive to replace the functionality of structopt which is unmaintained.

This also bumps the rust toolchain to 1.74.

@ColinKinloch ColinKinloch force-pushed the clap branch 2 times, most recently from ff62ff2 to 0947af2 Compare January 17, 2025 14:39
@sjoerdsimons sjoerdsimons requested a review from em- January 17, 2025 15:19
sjoerdsimons
sjoerdsimons previously approved these changes Jan 17, 2025
View reviewed changes
@ColinKinloch
Copy link
Contributor Author

ColinKinloch commented Jan 17, 2025 •
edited
Loading

Not sure why CI didn't fail before the rebase. deadpool-runtime v0.1.4 requires 1.75 so I guess I'll bump it the toolchain version.

@ColinKinloch
Replace unmaintained structopt with clap
b4fab4a 
Also update rust toolchain to 1.74
em-
em- approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@em- em- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@em- em- added this pull request to the merge queue Jan 20, 2025
Merged via the queue into collabora:main with commit 589b8f3 Jan 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@em- em- em- approved these changes

@sjoerdsimons sjoerdsimons sjoerdsimons left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ColinKinloch @em- @sjoerdsimons