DRYD-1326: Update exit reasons list #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray-lee
requested changes
Jan 18, 2024
ray-lee
requested changes
Jan 19, 2024
| @@ -3,28 +3,13 @@ import { defineMessages } from 'react-intl'; | |||
| export default { | |||
| exitReasons: { | |||
| values: [ | |||
| 'deaccession', | |||
| 'disposal', | |||
| 'returnofloan', | |||
There was a problem hiding this comment.
You actually need to keep these values. The messages can be deleted because they'll be inherited, but the values won't. The values need to be repeated, because if they were merged, you wouldn't be able to control the ordering. (Also you wouldn't be able to delete values, if that's what you wanted.)
There was a problem hiding this comment.
Ah I see, I should have tested again before pushing but moved on to some other things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds values to exit reasons list
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1326
This is just updating the exit reasons list to include additional values for PublicArt
How should this be tested? Do these changes have associated tests?
Dependencies for merging? Releasing to production?
The old value for
returnofloandid not have any spaces in it, so I left it as is.Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
@mikejritter tested against a local instance