Implement various fixes post visual classes overhaul.

colour-science · Oct 29, 2023 · 0d8be2a · 0d8be2a
1 parent 34b6b8e
commit 0d8be2a
Show file tree

Hide file tree

Showing 11 changed files with 12 additions and 2 deletions.
diff --git a/colour_visuals/diagrams.py b/colour_visuals/diagrams.py
@@ -489,13 +489,13 @@ def update(self):
                 [-1, 3]
             )
         else:
-            colours = np.tile(self._colour, (positions.shape[0], 1))
+            colour = np.tile(self._colour, (positions.shape[0], 1))
 
         self._spectral_locus = gfx.Line(
             gfx.Geometry(
                 positions=as_contiguous_array(positions),
                 colors=as_contiguous_array(
-                    append_channel(colours, self._opacity)
+                    append_channel(colour, self._opacity)
                 ),
             ),
             gfx.LineSegmentMaterial(

diff --git a/colour_visuals/rgb_scatter.py b/colour_visuals/rgb_scatter.py
@@ -190,6 +190,11 @@ def RGB(self, value: ArrayLike):
     def update(self):
         """Update the visual."""
 
+        if self._is_update_blocked:
+            return
+
+        self.clear()
+
         XYZ = RGB_to_XYZ(self._RGB, self._colourspace)
 
         positions = colourspace_model_axis_reorder(

diff --git a/colour_visuals/rosch_macadam.py b/colour_visuals/rosch_macadam.py
@@ -173,6 +173,11 @@ def __init__(
     def update(self):
         """Update the visual."""
 
+        if self._is_update_blocked:
+            return
+
+        self.clear()
+
         colourspace = CONSTANTS_COLOUR_STYLE.colour.colourspace
 
         XYZ = XYZ_outer_surface(

diff --git a/docs/_static/Plotting_VisualAxes.png b/docs/_static/Plotting_VisualAxes.png
diff --git a/docs/_static/Plotting_VisualChromaticityDiagramCIE1931.png b/docs/_static/Plotting_VisualChromaticityDiagramCIE1931.png
diff --git a/docs/_static/Plotting_VisualChromaticityDiagramCIE1960UCS.png b/docs/_static/Plotting_VisualChromaticityDiagramCIE1960UCS.png
diff --git a/docs/_static/Plotting_VisualChromaticityDiagramCIE1976UCS.png b/docs/_static/Plotting_VisualChromaticityDiagramCIE1976UCS.png
diff --git a/docs/_static/Plotting_VisualSpectralLocus2D.png b/docs/_static/Plotting_VisualSpectralLocus2D.png
diff --git a/docs/_static/Visuals_001.png b/docs/_static/Visuals_001.png
diff --git a/docs/_static/Visuals_002.png b/docs/_static/Visuals_002.png
diff --git a/docs/_static/Visuals_003.png b/docs/_static/Visuals_003.png