Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve check for subscription_created_at attribute #407

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Improve check for subscription_created_at attribute #407

merged 1 commit into from
Dec 21, 2023

Conversation

malessani
Copy link
Contributor

Closes #406

What I did

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@malessani malessani added the bug Something isn't working label Dec 21, 2023
@malessani malessani requested a review from gciotola December 21, 2023 13:12
@malessani malessani self-assigned this Dec 21, 2023
gciotola
gciotola approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@gciotola gciotola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review - OWASP - 407.xlsx

@malessani malessani merged commit b930677 into main Dec 21, 2023
1 check passed
@malessani malessani deleted the fix/check-order-with-subscriptions branch December 21, 2023 13:30
@malessani
Copy link
Contributor Author

🎉 This PR is included in version 4.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gciotola gciotola gciotola approved these changes

Assignees

@malessani malessani

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid displaying a warning message when checking subscription_created_at attribute
2 participants
@malessani @gciotola