Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock upgrade: add more tests #17845

Merged
merged 1 commit into from
Feb 25, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions test/integration/lockfile/test_user_overrides.py
Original file line number Diff line number Diff line change
Expand Up @@ -435,3 +435,25 @@ def test_lock_upgrade_path(self):
lock = c.load("conan.lock")
assert "libd/1.1" in lock
assert "libd/1.2" not in lock


def test_lock_upgrade_new_requirement(self):
c = TestClient(light=True)
c.save({"liba/conanfile.py": GenConanfile("liba").with_requires("libb/1.0"),
"libb/conanfile.py": GenConanfile("libb").with_requires("libc/1.0"),
"libc/conanfile.py": GenConanfile("libc"),
"libd/conanfile.py": GenConanfile("libd")})
c.run(f"export liba --version=1.0")
c.run(f"export libb --version=1.0")
c.run(f"export libc --version=1.0")
c.run(f"export libd --version=1.0")
c.save({f"conanfile.py": GenConanfile().with_requires(f"liba/[>=1.0 <2]")})
c.run("lock create .")

c.save({"libb/conanfile.py": GenConanfile("libb").with_requires("libd/1.0")})
c.run(f"export libb --version=2.0")
c.run("lock upgrade --requires='libb/[>=2]' --update-requires='libb/*'")
lock = c.load("conan.lock")
assert "libb/2.0" in lock
assert "libd/1.0" in lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

assert "libc/1.0" in lock # TODO: libc should be removed from lockfile? It is not required anymore...
Loading