VCVars: Fix generation if OS is set to WindowsStore #17849
Merged
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
memsharded
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
thanks for your contribution @mkskelet
Looking good, I have launched the CI to test the change.
Could you please have a look and sign the CLA, so we can merge this? Thanks!
AbrilRBS
approved these changes
Feb 26, 2025
|
Merged, it will be in the next Conan 2.14 (not todays 2.13, sorry, that was already closed). Thanks again for your contribution! |
|
Sounds good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Fixes VCVars vcvarsall.bat generation if OS is set to WindowsStore.
Docs: Omit
added test for VCVars generator targeting armv8 WindowsStore
Refer to the issue that supports this Pull Request.
If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
I've read the Contributing guide.
I've followed the PEP8 style guides for Python code.
I've opened another PR in the Conan docs repo to the
developbranch, documenting this one.