-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add hooks for validate method #17856
Merged
memsharded
merged 15 commits into
conan-io:develop2
from
uilianries:feature/hook-validate
Mar 10, 2025
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f0b295f
Add test for pre_validate_build hook
uilianries 2b92afb
Add pre_validate_build hook
uilianries a7511f9
Add post_validate_build hook
uilianries e3715f2
Adapt test to support both validate and validate_build
uilianries 51bdc7d
Add pre_validate hook
uilianries 58cae01
Add post_validate hook
uilianries 16fafd4
Pass hook manager by Compatibility
uilianries 333e335
Merge branch 'develop2' into feature/hook-validate
uilianries 0615850
Revert hook-manager usage
uilianries 59c6a83
Use hook manager from conan API
uilianries 13e971b
Pass missing hook manager to compute_package_id
uilianries a71eaaa
Remove hook support for validate_build
uilianries be0cb56
Merge branch 'develop2' of github.com:conan-io/conan into feature/hoo…
uilianries 499afd9
Remove hook manager for compatibility
uilianries 57878a1
Remove any trace of hook manager from compatilibity
uilianries File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked with @AbrilRBS about this. It looks better than changing more methods because we need to forward the hook manager to
run_validate_package_id