Fix cmake target not generated with CMake2 generator when only system… #17868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_libs are defined
|
|
memsharded
reviewed
Feb 28, 2025
There was a problem hiding this comment.
Hi @hwwan80
Thanks for your contribution.
This would need a bit more testing, I'll try to have a look and add some testing to cover this case to move this forward for next release.
|
Merged with a new added test, it will be in next Conan 2.14 Thanks very much for your contribution again, and thanks specially for testing the new incubating CMakeConfigDeps! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Omit
Docs: Omit
…_libs are defined
When trying to use the recipes in conan-center-index which refer to system version such as xorg/system or opengl/system, the generated target cmake file do not contain the required target when using the CMakeDep2 generator as it only defined system_libs in cpp_info. This PR attempt to fix this