Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMakeConfigDeps issues with components with types #17946

Draft
wants to merge 4 commits into
base: develop2
Choose a base branch
from
Draft

Fix CMakeConfigDeps issues with components with types #17946

wants to merge 4 commits into from
+50 −2

Conversation

memsharded
Copy link
Member

Changelog: BugFix: Solve issue with component.type for incubating CMakeConfigDeps
Docs: Omit

Close #17942

@memsharded memsharded mentioned this pull request Mar 11, 2025
Open
memsharded and others added 2 commits March 12, 2025 14:56
@memsharded @NokiDev
Update test/integration/toolchains/cmake/cmakedeps2/test_cmakedeps.py
a67e184 
Co-authored-by: Timothé <12487815+NokiDev@users.noreply.github.com>
@memsharded
extra test
4ac46f5
@memsharded
Copy link
Member Author

Thanks very much for your test reproducing it.
I have also added a new test based on it, to cover the usage of components of another package too.

@memsharded memsharded changed the title just the test Fix CMakeConfigDeps issues with components with types Mar 12, 2025
@memsharded memsharded added this to the 2.15.0 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NokiDev NokiDev NokiDev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

[bug] - CMakeConfigDeps components depending on components from same package raise an error
2 participants
@memsharded @NokiDev