Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close r-base 4.4 and m2w64-ucrt migration #7024

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Feb 13, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@isuruf isuruf requested a review from a team as a code owner February 13, 2025 04:45
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@isuruf
Copy link
Member Author

isuruf commented Feb 13, 2025

This is almost done: https://conda-forge.org/status/migration/?name=r-base44_and_m2w64-ucrt

I think it's better to close this now and use m2w64 UCRT compilers everywhere including staged-recipes.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on this huge piece of work (especially the toolchain bringup), and thanks to everyone who participated in the migration! 🥳 🚀

@jakirkham
Copy link
Member

Thanks Isuru and everyone who helped push this forward! 🙏

Glanced at the migrator status and the only things that stuck out were

This msmpi can continue to be worked on after the migration

go1.4-bootstrap needs migration. So put together PR: conda-forge/go1.4-bootstrap-feedstock#7

@jakirkham
Copy link
Member

go1.4-bootstrap needs migration. So put together PR: conda-forge/go1.4-bootstrap-feedstock#7

Actually this may not be needed. Checking whether go still uses this: conda-forge/go-feedstock#269

@isuruf
Copy link
Member Author

isuruf commented Feb 14, 2025

Good to merge then?

@h-vetinari h-vetinari merged commit 5c5a5c6 into conda-forge:main Feb 14, 2025
3 checks passed
@jakirkham
Copy link
Member

Yep 👍

Thanks Isuru! 🙏

@h-vetinari
Copy link
Member

For completeness/traceability, here are the PRs that weren't merged yet:

image

image

@jakirkham
Copy link
Member

Would just add that this would be a great blogpost 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants