Skip to content

Commit

Permalink
Merge pull request #2241 from conda-forge/beckermr-patch-2
Browse files Browse the repository at this point in the history
  • Loading branch information
beckermr authored Feb 16, 2025
2 parents 7564701 + f389601 commit 6595f17
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 6 deletions.
5 changes: 3 additions & 2 deletions conda_smithy/linter/lints.py
Original file line number Diff line number Diff line change
Expand Up @@ -584,8 +584,9 @@ def lint_require_lower_bound_on_python_version(
lints.append(
"noarch: python recipes are required to have a lower bound "
"on the python version. Typically this means putting "
"`python >=3.6` in **both** `host` and `run` but you should check "
"upstream for the package's Python compatibility."
"`python >={{ python_min }}` in the `run` section of your "
"recipe. You may also want to check the upstream source "
"for the package's Python compatibility."
)


Expand Down
23 changes: 23 additions & 0 deletions news/2241-noarch-again.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
**Added:**

* <news item>

**Changed:**

* Changed the ``noarch: python`` lint text to match the new syntax. (#2241)

**Deprecated:**

* <news item>

**Removed:**

* <news item>

**Fixed:**

* <news item>

**Security:**

* <news item>
9 changes: 5 additions & 4 deletions tests/test_lint_recipe.py
Original file line number Diff line number Diff line change
Expand Up @@ -1640,10 +1640,11 @@ def test_bad_requirements_order(self):

def test_noarch_python_bound(self):
expected_message = (
"noarch: python recipes are required to have a lower bound "
"on the python version. Typically this means putting "
"`python >=3.6` in **both** `host` and `run` but you should check "
"upstream for the package's Python compatibility."
"noarch: python recipes are required to have a lower bound on the "
"python version. Typically this means putting "
"`python >={{ python_min }}` in the `run` section of your "
"recipe. You may also want to check the upstream source for "
"the package's Python compatibility."
)
meta = {
"build": {"noarch": "python"},
Expand Down

0 comments on commit 6595f17

Please sign in to comment.