-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow and validate schema_version
key in v1 recipes
#2207
Conversation
Allow the v1 recipes to contain a top-level `schema_version` key, and expect it to be ordered first. The key is defined in CEP 14: https://conda.org/learn/ceps/cep-0014#schema-version Fixes conda-forge#2201
For the time being, just verify that `schema_version` is 1 when using `recipe.yaml` format, and refuse to lint if it is not. In the future, the code will probably need to be adapted to change `recipe_version` based on `schema_version`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
thanks! Once this is in, I'll try transitioning the rest of the feedstocks I maintain to rattler build with conda-recipe-manager and see if there are any other hiccups |
@mgorny @wolfv @beckermr I am still seeing errors with v3.45.2: https://github.com/conda-forge/conda-forge-webservices/actions/runs/12769039945/job/35590721570#step:5:1 Perhaps there is some config I am missing? EDIT: the PR is conda-forge/scipy-stubs-feedstock#10 |
Ahhhh that is a bug in rattler not in conda-smithy. |
right, the linter passes now, but same rerender failure https://github.com/conda-forge/conda-forge-webservices/actions/runs/12769927672/job/35593584345 |
Yes. That rerender failure is in rattler/build. Please submit an issue to the rattler-build github repository. |
Fixed it here: prefix-dev/rattler-build#1332 |
Checklist
news
entrypython conda_smithy/schema.py
)Allow the
schema_version
key in v1 recipes, and validate that it has a value of 1.For testing:
schema_version
is covered by most of the existing testsschema_version: 1
, I've modified ourtorchvision.recipe
schema_version
, I've added an explicit test