Fix handling package version 0, refactor and deduplicate #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the boolean logic that caused version of 0 (that is a valid package version) to be incorrectly interpreted as missing, and emit linter errors. While at it, deduplicate the recipe v0 linter to reuse the utility code added along with v1 lints, and refactor the v1 linter to reduce the number of redundant conditions and make the logic easier to follow. Fixes conda-forge#2215
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentrypython conda_smithy/schema.py)Fix the boolean logic that caused version of 0 (that is a valid package version) to be incorrectly interpreted as missing, and emit linter errors. While at it, deduplicate the recipe v0 linter to reuse the utility code added along with v1 lints, and refactor the v1 linter to reduce the number of redundant conditions and make the logic easier to follow.
Fixes #2215